#692 Fix Definition Value

[abdallahalsamman]

🚨Please review the guidelines for contributing to this repository.

Proposed changes

Fixes issue #692

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.

• I have read the CONTRIBUTING doc
• I agree to contribute my changes under the project's LICENSE
• I have checked that the unit tests pass locally with my changes
• I have checked the style of the new code (lint/pep).
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, please explain why you chose
the solution you did and what alternatives you considered, etc.

Reviewers

If you know the person who can review your code please add a @mention.

@g-kartik

[coveralls]

Coverage decreased (-0.09%) to 73.853% when pulling 9c2595f on evexoio:692-fix-definition-value into a82edb9 on coursera-dl:master.

[ghost]

I have applied your patch and tried to download again but it again gave the same error (refer attachment).

[abdallahalsamman]

@g-kartik Notice the path of the file api.py,

its coming from the python coursera-dl package, and not coming from your local repo,

can we do ./coursera-dl iot instead of coursera-dl iot.

that should make it use the local repo code. :) <3

[ghost]

@evexoio Hi I am new to github. So I just followed your instructions.
I applied the patch and then tried to run ./coursera-dl iot
It gave an error that no such file or directory.
Then what I did was, I just copied the api.py file to which the patch was applied to the coursera-dl package directory and repalced the original file.
But I again got the same error.
Please help me if I am wrong.

[abdallahalsamman]

Notice your current path: its ~/Desktop/coursera-dl/coursera, instead it should be ~/Desktop/coursera-dl

so please do

cd ~/Desktop/coursera-dl
./coursera-dl iot

let me know what happens 👍

[ghost]

Hi, it gives the following error

[abdallahalsamman]

@g-kartik sorry for the back and forth, can you try python coursera-dl iot in that same directory desktop/coursera-dl?

[ghost]

Ok, I have tried that too. It is giving the same error again.

[ghost]

Hi, can you spare some time to resolve this issue?
Thanks!