Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some SyntaxWarnings #783

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Ferenc-
Copy link

@Ferenc- Ferenc- commented Nov 2, 2020

  • On Python 3.8.5 during normal execution the following is logged:
    SyntaxWarning: "is" with a literal. Did you mean "=="?

馃毃Please review the guidelines for contributing to this repository.

Proposed changes

Eliminate some annoying SyntaxWarning messages.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I agree to contribute my changes under the project's LICENSE
  • I have checked that the unit tests pass locally with my changes
  • I have checked the style of the new code (lint/pep).
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

This should not change the functionality.

Reviewers

@felker @balta2ar

* On Python 3.8.5 during normal execution the following is logged:
  SyntaxWarning: "is" with a literal. Did you mean "=="?
@Ferenc-
Copy link
Author

Ferenc- commented Nov 2, 2020

The CI failures seem to be non-relevant:

No matching distribution found for urllib3>=1.23 (from -r requirements.txt (line 4))
Command exited with code 1

Is there a way to re-trigger it?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 73.594% when pulling 1e058b3 on Ferenc-:SYNTAX_FIX into f9a9a26 on coursera-dl:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 73.594% when pulling 1e058b3 on Ferenc-:SYNTAX_FIX into f9a9a26 on coursera-dl:master.

@Ferenc-
Copy link
Author

Ferenc- commented Nov 5, 2020

@felker could you take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants