-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No downloadable video via "--prefer cdn" option #341
Comments
Actually it is not a question of the new layout. The current edx extractor looks for the direct video URLs in the in the metadata, and for this given course the metadata info is not there. 'sources": []'. DEFAULT_FILE_FORMATS = ['e?ps', 'pdf', 'txt', 'doc', 'xls', 'ppt', I am sorry if this is not the ideal solution, but I have been thinking about adding an option to overwrite file formats for cases like this one, and the code has everything to support it, I hope me or somebody else can implement this in the future. |
Actually I felt motivated and implemented it as a new set of options in PR_#352. Once this is merged I will close this issue. |
Add new options to support arbitrary file format extraction. From the pull request by @iemejia: ---- ## Proposed changes Currently the file formats extracted during parsing are fixed to some common formats. But it is possible that courses would require particular formats (e.g. java, jar, R, py, etc). I add three new options to allow this: --list-file-formats list the default file formats extracted --file-formats FILE_FORMATS appends file formats to be extracted (comma separated) --overwrite-file-formats if active overwrites the file formats to be extracted This can address the case where videos are not in the metadata but in the html e.g. adding the --file-formats=mp4. See Issue #341 ---- Thanks @iemejia for the excellent contribution.
I am closing this one since PR #352 is merged and it should address this issue. Please feel free to comment or reopen if you have further issues. |
Hi
It seems that, downloading from courses with new layouts is possible with youtube-dl. but "prefer cdn" option doesn't work in these courses. and i face "No downloadable video" comment. for example https://courses.edx.org/courses/BerkeleyX/Stat_2.3x/2T2014/info
The text was updated successfully, but these errors were encountered: