Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bs4.FeatureNotFound error #505

Merged
merged 2 commits into from
Jul 24, 2018

Conversation

purusharths
Copy link
Contributor

🚨Please review the guidelines for contributing to this repository.

Proposed changes

Fixed the bs4.FeatureNotFound Error (#434)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

  • I have read the CONTRIBUTING doc

  • I agree to contribute my changes under the project's LICENSE

  • I have checked that the unit tests pass locally with my changes

  • I have checked the style of the new code (lint/pep).

  • I have added tests that prove my fix is effective or that my feature works

  • I have added necessary documentation (if appropriate)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 48.016% when pulling 3ec15f0 on Jar-win:bs4-parser-error into 55f6e51 on coursera-dl:master.

@coveralls
Copy link

coveralls commented Apr 17, 2018

Coverage Status

Coverage increased (+24.6%) to 72.586% when pulling b811848 on Jar-win:bs4-parser-error into 55f6e51 on coursera-dl:master.

@rbrito rbrito merged commit fe82caa into coursera-dl:master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants