Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust the name input of the SubSection to the new HTML structure #516

Closed
wants to merge 1 commit into from

Conversation

kareemadel
Copy link

@kareemadel kareemadel commented Jul 5, 2018

Bug Fix

Proposed changes

The code was crashing on line 391 of the file edx_dl/parsing.py
AttributeError: 'NoneType' object has no attribute 'string'. It was because the section name path changed from s.a.div.span to s.a.div.div, so I changed it accordingly.
#514

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I agree to contribute my changes under the project's LICENSE
  • I have checked that the unit tests pass locally with my changes
  • I have checked the style of the new code (lint/pep).
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@coveralls
Copy link

coveralls commented Jul 5, 2018

Coverage Status

Coverage remained the same at 48.016% when pulling 933e1f7 on kareemadel:master into 55f6e51 on coursera-dl:master.

@bandupahile bandupahile mentioned this pull request Jul 30, 2018
@rbrito
Copy link
Member

rbrito commented Jul 30, 2018

Thank you very much, @kareemadel. I apparently merged another pull request that contained the same fix as yours.

I appreciate all the attention and interest that you have in edx-dl and, if you find other issues with the code, please do send other pull requests.

Thank you once again!

@rbrito rbrito closed this Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants