Add debugMode flag and only send sourceUrls if in debug mode
#207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 1, 2017 12:31
We're currently sending the `sourceUrl` extension on every response. However, this ends up being a very large response that is for debugging purposes only. This change adds a `debugMode` to the context, and we'll only send the sourceUrl data if the debug mode is enabled (it's disabled by default). Filters will be able to modify this flag, to allow for custom headers / authorization checking to enable debug mode.
vishalkuo
approved these changes
Aug 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
debugModeflag and only send sourceUrls if in debug mode …We're currently sending thesourceUrlextension on every response. However, this ends up being a very large response that is for debugging purposes only. This change adds adebugModeto the context, and we'll only send the sourceUrl data if the debug mode is enabled (it's disabled by default). Filters will be able to modify this flag, to allow for custom headers / authorization checking to enable debug mode.