Refactor the Fetcher API #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change refactors the fetcher to simplify the implementation and return more information about downstream errors. - Removes the concept of `TopLevelRequest`, instead turning the Fetcher into an implementation that only makes one request given a `ResourceName` and arguments. Initially, the plan was to allow the fetcher to make multiple requests at once, but that is not a priority anymore due to the engine refactor. - Removes models that are no longer used - Modifies the UrlLogging middleware to become a ResponseMetadata middleware, including the sourceUrl as well as response codes and error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the fetcher to simplify the implementation and return more information about downstream errors.
TopLevelRequest, instead turning the Fetcher into an implementation that only makes one request given aResourceNameand arguments. Initially, the plan was to allow the fetcher to make multiple requests at once, but that is not a priority anymore due to the engine refactor.We can now get nice error responses like this:
