Fix Re-ordering of Related Resource Ids #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- After merging a recent fix that de-duplicated ids we found that related resource `elementIds` and `elements` arrays were being re-ordered in a non-deterministic way after every request. - In particular our moduleIds were being re-ordered and the order has actual meaning. It turns out that the previous de-duplication fix had introduced sets and hence this non-determinism. - I’ve replaced the Set introduced in parseIds with a Seq and this has corrected the problem.
cliu587
approved these changes
Apr 3, 2018
| case ("ids", ids) => ids | ||
| } | ||
| private[this] def parseIds(request: NaptimeRequest): Seq[JsValue] = { | ||
| request.arguments.toSeq.filter { case (key, _) => key == "ids" }.map(_._2) |
There was a problem hiding this comment.
can you add a note that .toSeq is to respect order?
There was a problem hiding this comment.
sure thing. thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging a recent fix that de-duplicated ids we found that related resource
elementIdsandelementsarrays were being re-ordered in a non-deterministic way during every request. In particular our moduleIds were being re-ordered and the order has actual meaning.It turns out that the previous de-duplication fix had introduced sets and hence this non-determinism. I’ve replaced the Set introduced in parseIds with a Seq and this has corrected the problem.
I tested using prod-preview and now the problem has gone away.