Fixing field builder for passthrough exempt fields. #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliu587
approved these changes
Sep 11, 2018
There was a problem hiding this comment.
Thanks for adding the tests!
To publish the changes you will need to bump up the version in version.sbt and then follow instructions at https://docs.google.com/document/d/1Uns8vtmRt1YDwDEsKKhYls2jTn9bpgR4f2VRBRBRCHY/edit
Happy to sit down with you to go through this process some time this week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that
AnyDatacourier fields haven't been working correctly, which led to the following error:org.coursera.naptime.ari.graphql.schema.DataMapWithParent cannot be cast to com.linkedin.data.DataMap.The passthrough exempt field's
resolveparameter will now return aDataMapinstead of aDataMapWithParent. As a sanity check, this is also what we do in the case ofMapDataSchemafields—I'd expect the behavior to be the same.cc @cliu587