Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit query analysis error message #282

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Omit query analysis error message #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85d39a5
FCORE-562 Omitted QueryAnalysisError message due to security
gargrishabh75 Dec 17, 2020
93d621a
FCORE-562 Omitted QueryAnalysisError message due to security
gargrishabh75 Dec 17, 2020
24ec166
Returning uuid in error message and logging the error with the same
gargrishabh75 Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...aphql/src/main/scala/org/coursera/naptime/ari/graphql/controllers/GraphQLController.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

package org.coursera.naptime.ari.graphql.controllers

import java.util.UUID.randomUUID
import javax.inject._
import com.typesafe.scalalogging.Logger
import com.typesafe.scalalogging.StrictLogging
Expand Down Expand Up @@ -147,7 +148,9 @@ class GraphQLController @Inject()(
}
}.recover {
case error: QueryAnalysisError =>
OutgoingQuery(error.resolveError.as[JsObject], None)
val uuid = randomUUID().toString
logger.error("QueryAnalysisError- " + uuid, error)
OutgoingQuery(Json.obj("error" -> "QueryAnalysisError", "message" -> uuid), None)
case error: ErrorWithResolver =>
OutgoingQuery(error.resolveError.as[JsObject], None)
case error: Exception =>
Expand Down
2 changes: 1 addition & 1 deletion version.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
version in ThisBuild := "0.11.4"
version in ThisBuild := "0.11.5"