Serialize Courier default values #284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremycarroll
approved these changes
Mar 18, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
elin-coursera2
commented
Mar 18, 2022
| @@ -6,8 +6,6 @@ addSbtPlugin("org.coursera.courier" % "courier-sbt-plugin" % "2.1.4") | |||
|
|
|||
| addSbtPlugin("org.xerial.sbt" % "sbt-sonatype" % "1.1") | |||
|
|
|||
| addSbtPlugin("com.jsuereth" % "sbt-pgp" % "1.0.0") | |||
There was a problem hiding this comment.
I removed this because this dependency is so old that it was removed from Maven. There's a newer version at com.github.sbt:sbt-pgp:2.1.2, but it doesn't seem to be compatible with sbt 0.13.
I think this still works because it seems sbt 0.13 actually bundles a copy of the original com.jsuereth jar.
|
This didn't actually seem to fix the issue when I tested it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Courier default values were not correctly being serialized to JSON because the previous
Writeslogic iterated through fields contained in the underlyingDataMap, which would not include unset fields with default values. This PR addresses this issue by iterating through the fields declared in the record schema instead, and explicitly uses the default value if a field is unset and a default exists.