omit invalid naptime resource schemas in graphql schema builder #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -66,10 +70,26 @@ class SangriaGraphQlSchemaBuilder(resources: Set[Resource], schemas: Map[String, | |||
| val schemaErrors = topLevelResourceObjectsAndErrors.foldLeft(SchemaErrors.empty)(_ ++ _.errors) | |||
|
|
|||
| val dedupedResources = topLevelResourceObjects.groupBy(_.name).map(_._2.head).toList | |||
|
|
|||
| // first, try to individually generate graphql schemas from each resource, and discard | |||
There was a problem hiding this comment.
I don't think we should have references to our internal tools in the OSS repo.
Should this be an option? We should maintain compatibility with existing integrations. Alternatively, we could potentially have a 2nd implementation to provide this functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
SangriaGraphQlSchemaBuilderso that it is able to compose a schema for multiple resources, even if one or more of them do not pass validation, by excluding resources with invalid schemas before composing.