Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SSR POC #1536

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: SSR POC #1536

wants to merge 1 commit into from

Conversation

Josh-Cena
Copy link
Member

This is needed for #1427 to work.

@bearsyankees My website is fully server-rendered with react-helmet. You can check the impl here:

The code here is slightly adapted to make bun work.

Next we need to figure out how to serve these pre-rendered HTML so they get picked up by social media.

Copy link

Thanks for your pull request! The preview of your changes is available at https://ssr.preview.coursetable.com.

Copy link

github-actions bot commented Dec 30, 2023

Size Change: 0 B

Total Size: 3.03 MB

ℹ️ View Unchanged
Filename Size
build/assets/About.js 9.06 kB
build/assets/About.css 260 B
build/assets/authentication.js 64 B
build/assets/brace-fold.es.js 2.75 kB
build/assets/Challenge.js 60.3 kB
build/assets/Challenge.css 251 B
build/assets/closebrackets.es.js 4.28 kB
build/assets/codemirror.es.js 581 B
build/assets/codemirror.es2.js 184 kB
build/assets/comment.es.js 4.64 kB
build/assets/CourseModalEvaluations.js 27.2 kB
build/assets/CourseModalEvaluations.css 524 B
build/assets/CourseModalOverview.css 1.9 kB
build/assets/CourseModalOverview.js 14.6 kB
build/assets/dialog.es.js 614 B
build/assets/dialog.es2.js 2.51 kB
build/assets/entry-index.js 1.23 MB
build/assets/fall23.css 404 B
build/assets/fall23.js 8.56 kB
build/assets/FAQ.js 8.88 kB
build/assets/FAQ.css 422 B
build/assets/foldgutter.es.js 5.92 kB
build/assets/forEachState.es.js 230 B
build/assets/Graphiql.js 536 kB
build/assets/Graphiql.css 409 kB
build/assets/GraphiqlLogin.js 501 B
build/assets/graphql.js 13.3 kB
build/assets/hint.es.js 880 B
build/assets/hint.es2.js 3.27 kB
build/assets/index.js 49.4 kB
build/assets/index.css 207 kB
build/assets/info-addon.es.js 2.61 kB
build/assets/info.es.js 3.87 kB
build/assets/javascript.es.js 20.3 kB
build/assets/Join.js 898 B
build/assets/Join.css 314 B
build/assets/jump-to-line.es.js 1.74 kB
build/assets/jump.es.js 3.03 kB
build/assets/Landing.js 2.17 kB
build/assets/Landing.css 636 B
build/assets/lint.es.js 5.93 kB
build/assets/lint.es2.js 32.1 kB
build/assets/lint.es3.js 4.87 kB
build/assets/matchbrackets.es.js 621 B
build/assets/matchbrackets.es2.js 3.36 kB
build/assets/medium.js 1.56 kB
build/assets/mode-indent.es.js 326 B
build/assets/mode.es.js 714 B
build/assets/mode.es2.js 1.68 kB
build/assets/mode.es3.js 1.48 kB
build/assets/NotFound.js 466 B
build/assets/parser.js 27.5 kB
build/assets/Privacy.js 25.3 kB
build/assets/Privacy.css 429 B
build/assets/Range.js 530 B
build/assets/SchemaReference.es.js 3.06 kB
build/assets/search.es.js 6.78 kB
build/assets/searchcursor.es.js 620 B
build/assets/searchcursor.es2.js 5.8 kB
build/assets/show-hint.es.js 11.5 kB
build/assets/sublime.es.js 16.1 kB
build/assets/Thankyou.js 365 B
build/assets/Tutorial.css 61 B
build/assets/Tutorial.js 51.1 kB
build/assets/useApolloClient.js 151 B
build/assets/WorksheetLogin.js 512 B

compressed-size-action

@Josh-Cena
Copy link
Member Author

I haven't wired it to any deployment yet. To test the build output, run cd frontend && bun run build:ssr && bun src/ssr/pre-render.ts.

@bearsyankees
Copy link
Member

@Josh-Cena is this still viable/ something we want to do

@Josh-Cena
Copy link
Member Author

I definitely want to do this eventually, but not sure if it yields any immediate value. We have to migrate off Vercel static serving first.

@Josh-Cena Josh-Cena force-pushed the master branch 3 times, most recently from 507a9e0 to 28c12bf Compare April 18, 2024 00:00
@Josh-Cena Josh-Cena force-pushed the master branch 3 times, most recently from ef76603 to 3f2e6c5 Compare May 16, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants