Fix coursier/coursier#1957: Always use the original sbt launcher. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the new features merged in coursier: * The ability to install from the contents of a .zip file * The `prebuilt` launcher type to ensure that we always install sbt and sbtn using their official distribution.
apps/resources/sbt.json
Outdated
Comment on lines
6
to
7
| "org.scala-sbt:sbt-launch:latest.stable", | ||
| "io.get-coursier.sbt:sbt-runner:latest.stable" |
There was a problem hiding this comment.
I think we should keep those. These can be helpful when running cs launch sbt, which doesn't use prebuilt binaries for now.
apps/resources/sbt.json
Outdated
Comment on lines
9
to
14
| "properties": { | ||
| "jline.shutdownhook": "false", | ||
| "jna.nosys": "true" | ||
| }, | ||
| "javaOptions": ["-Xms512m", "-Xss2m"], | ||
| "jvmOptionFile": ".jvmopts" |
There was a problem hiding this comment.
Same as above. We should keep those. These should be ignored by cs install anyway, when it's using the prebuilt launcher.
It's still a draft in the sense that, if it is merged now, all default installs of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new features merged in coursier:
prebuiltlauncher typeto ensure that we always install sbt and sbtn using their official distribution.