Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve footer #1346

Merged
merged 3 commits into from Sep 6, 2019
Merged

Improve footer #1346

merged 3 commits into from Sep 6, 2019

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Sep 4, 2019

The most prominent elements of the footer w/o this change are Docs and Community; but clicking them does nothing.

Docs is used at the top of the page w/ a similar style to link to Docs -- this change makes it link to that same place.

In order to avoid leaving Community as the only very visible text without a link, I've decided to link it to Gitter, which is indeed a community, and the best way to have that consistent w/ Docs is by swapping the order.

Copy link
Member

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsoref! It's nicer this way, yes.

@alexarchambault alexarchambault merged commit 2f39536 into coursier:master Sep 6, 2019
@jsoref jsoref deleted the improve-footer branch September 6, 2019 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants