Switch build to Mill #2067
Merged
Switch build to Mill #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful in upcoming commits switching to mill
Tested in upcoming commits switching to mill
alexarchambault
force-pushed
the
mill
branch
4 times, most recently
from
dedb640
to
d848e8d
Compare
This comment has been minimized.
This comment has been minimized.
alexarchambault
force-pushed
the
mill
branch
4 times, most recently
from
aa5628f
to
84da0e5
Compare
ckipp01
reviewed
Jul 6, 2021
Comment on lines
+37
to
+38
| Using the default import functionality of Metals is _not_ recommended. Instead, | ||
| generate bloop configuration files with |
There was a problem hiding this comment.
I've seen you write this in a couple different repos now. Is there anything on the Metals side that we could do to improve the import situation with Mill? What makes you strongly recommend not relying on the built-in functionality? I'd love to improve this so we don't have to recommend users not to utilize the built-in functionality. Let me know your thoughts @alexarchambault .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.