Be fine with Mill-generated manifests #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mill doesn't add Implementation-Vendor-Id and Specification-Title in the manifests it generates, which the main class detection code uses to pick a main class. These changes default to the main class from the first JAR in the class path (which has been determistic for some time now, and corresponds to the JAR of the first specified dependency), no matter its Implementation-Vendor-Id and Specification-Title attributes.
So that former cs launcher can run newer versions too.
|
I'm seeing this still on 20.04, on the current release downloaded from the launchers repo: $ /tmp/coursier_installerbw_3tcf1/cs setup --yes
Checking if a JVM is installed
Found a JVM installed under /usr/lib/jvm/java-11-openjdk-arm64.
Checking if ~/.local/share/coursier/bin is in PATH
Should we add ~/.local/share/coursier/bin to your PATH via ~/.profile, ~/.bash_profile? [Y/n] Y
Checking if the standard Scala applications are installed
Found ammonite
Found cs
Found coursier
Found scala
Found scalac
Found sbt
No main class found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mill doesn't add Implementation-Vendor-Id and Specification-Title in the
manifests it generates, which the main class detection code uses to pick
a main class.
These changes default to the main class from the first JAR in the class
path (which has been determistic for some time now, and corresponds to the
JAR of the first specified dependency), no matter its
Implementation-Vendor-Id and Specification-Title attributes.