Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default JVM to adoptium@11 #2796

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Set default JVM to adoptium@11 #2796

merged 1 commit into from
Sep 6, 2023

Conversation

julienrf
Copy link
Collaborator

No description provided.

@julienrf
Copy link
Collaborator Author

May fix #2678

@julienrf julienrf linked an issue Jun 30, 2023 that may be closed by this pull request
@julienrf
Copy link
Collaborator Author

The CI is green but I am not sure how well this is covered by the tests :-/ @alexarchambault what do you think?

Copy link
Collaborator

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm also not sure if there will be any problems caused by this change,

Copy link
Member

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @julienrf! Merging, but we might as well update to Java 17…

@alexarchambault alexarchambault merged commit 7224a68 into main Sep 6, 2023
22 checks passed
@alexarchambault alexarchambault deleted the default-adoptium-11 branch September 6, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cs setup can't find a JVM cs setup fails on MacOS since it defaults to a non-existing GraalVM version
3 participants