Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the sbt-coursier version on site to actual #2973

Merged
merged 2 commits into from May 5, 2024

Conversation

danicheg
Copy link
Contributor

@danicheg danicheg commented May 2, 2024

Hey there. I observed a minor issue: the version of sbt-coursier on site is outdated and generally not automatically updated by Scala Steward / dependabot when new versions arrive. In this PR, we update the version and add a caution on where to pick the latest version on site.

Copy link
Collaborator

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgodzik
Copy link
Collaborator

tgodzik commented May 5, 2024

I think rebasing on top of main should fix the CI issue.

@danicheg
Copy link
Contributor Author

danicheg commented May 5, 2024

Yeah, definitely. Or maybe we can move on without that, since I changed only site related things?

@tgodzik
Copy link
Collaborator

tgodzik commented May 5, 2024

sure, should be fine!

@tgodzik tgodzik merged commit 616202a into coursier:main May 5, 2024
22 of 23 checks passed
@danicheg danicheg deleted the sbt-coursier-on-site branch May 5, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants