Import correct resolver from librarymanagement

[leonardehrenfried]

This might be a solution for #745 by importing the correct version of the Resolver type from sbt.librarymanagement rather than sbt thereby sidestepping the issue described here: sbt/librarymanagement#190 (comment)

[leonardehrenfried]

Ok, this doesn't work on 0.13, as sbt.librarymanagement.Resolver isn't in sbt-compat yet.

I've added a PR for this: dwijnand/sbt-compat#8

[leonardehrenfried]

I'm getting test failures that seem unrelated:

Line 1:
  expected: org.webjars.bower:jquery:3.2.1:compile
  got:      org.webjars.bower:jquery:3.3.1:compile
X coursier.test.CentralNexus3ProxyTests.versionInterval 14081ms 
  utest.AssertionError: assert(result == expected)
  result: scala.collection.immutable.Vector[String] = Vector(org.webjars.bower:jquery:3.3.1:compile,
   org.webjars.bower:jquery-mousewheel:3.1.13:compile, org.webjars.bower:malihu-custom-scrollbar-plu
  gin:3.1.5:compile)
  expected: Seq[String] = WrappedArray(org.webjars.bower:jquery:3.2.1:compile, org.webjars.bower:jqu
  ery-mousewheel:3.1.13:compile, org.webjars.bower:malihu-custom-scrollbar-plugin:3.1.5:compile)

jquery 3.3.0 and 3.3.1 were released two days ago. Seems that the real world has changed. I'm going to fix the test, if that's ok.

[leonardehrenfried]

Closing and reopening to rerun CI.

[leonardehrenfried]

Ok, now I'm officially confused.

When I change the test expectation, the test fails because it is expecting version 3.2.1, which is the old version of jquery.

Can you help?

[alexarchambault]

@leonardehrenfried I'll have a look. I think the failing test might need to be put behind a condition like that one. The main tests just rely on what's in this repo, so shouldn't need to be updated like this. But the tests are also run via docker-based Nexus proxies, which download stuff… The isActualCentral condition makes things not run there.

[alexarchambault]

@leonardehrenfried Rebase if you'd like (as the nexus proxy tests are disabled), CI should be fine then.

[leonardehrenfried]

Ok, rebased.

[alexarchambault]

@leonardehrenfried You want this to be merged, right? (I mean, it's not just for testing?)

[leonardehrenfried]

Yes, I'd like this to be merged. Even if it doesn't resolve my issue, it is the correct import. Am 31.01.2018 2:11 nachm. schrieb "Alexandre Archambault" < notifications@github.com>:

…

@leonardehrenfried <https://github.com/leonardehrenfried> You want this to be merged, right? (I mean, it's not just for testing?) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#746 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJPModhTWdQeCqpsLIVxuAvWdh6dYV7ks5tQGZxgaJpZM4Rk2Yx> .

[alexarchambault]

Ok, merging then!