Add json report version and documentation #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wisechengyi
commented
Jan 22, 2018
•
wisechengyi
commented
- Add version number to the json report
- Add documentation and borrow Pants' export versioning guideline: https://github.com/pantsbuild/pants/blob/afa6a286f1a9a786093e95b605de9ef043cb2aeb/src/python/pants/backend/project_info/tasks/export.py#L49-L59
wisechengyi
changed the title
|
@alexarchambault any preference where I put the readme, under |
|
Planning on merging this one in the next 24 hours if no further feedback given. |
There was a problem hiding this comment.
I think the new documentation could be put under doc/ too, like doc/cli.md. With the current master, sbt tut would process that file. #758 moves the tut-processed README.md under doc/readme/, so that we can add things under doc/.
|
@wisechengyi If you're ok with it, move |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.