New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to fetch artifact with a given url #774
Merged
alexarchambault
merged 36 commits into
coursier:master
from
dotordogh:dotordogh/issue-710
Feb 22, 2018
Merged
Changes from 30 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
d562a12
changes
dotordogh 2c6f12f
changes to Attributes
dotordogh 362b170
make changes
dotordogh b590fda
fix merge conflicts
dotordogh fd2b355
add test and fix bug
dotordogh 6a91c1f
add more tests
dotordogh e70a73f
Merge branch 'master' into dotordogh/exp-w-cli-I
dotordogh d3a1337
fix failing tests
dotordogh 7e9775a
fix parentheses
dotordogh b46b1be
remove comments I added and add test that's guarenteed not to exist i…
dotordogh 60cebe8
remove Attributes third parameter and refactor Parse's moduleVersionC…
dotordogh d04f46d
update some return types and methods in the Helper class
dotordogh aa583b8
Merge branch 'master' into dotordogh/issue-710-refactor
dotordogh d5b189b
return FallbackDependenciesRepository back to original state
dotordogh 92b185d
refactor helper
dotordogh 4912757
remove url from attributes
dotordogh 3fe0507
fix tests and add cache to extra in build.sbt
dotordogh 684f055
remove FallbackDepsRepo from sbt-coursier
dotordogh 4245f11
add variable for url and call encode in tests
dotordogh b8bddb3
update tests and helper to have proper behavior
dotordogh 0a0c930
remove setting deps to intransitive when url is present and add two t…
dotordogh 53d9851
add more tests, implement @wisechengyi's comments
dotordogh 56cbf2e
fix nits
dotordogh 935bacc
update ParseTests because some failed
dotordogh 3b33d07
fix tests
dotordogh 7333f0f
incorporate feedback from @alexarchambault and @wisechengyi
dotordogh fb6ba3f
update ParseTests to check for returned error vs thrown error
dotordogh dcaa484
remove one test that is covered in ParseTests
dotordogh 3d8d3b5
fix nits
dotordogh d5c5e6a
add back deleted brackets
dotordogh f72ba7c
return errors in Left without using return statement
dotordogh e27a6de
revert change because it's broken
dotordogh 080fcbf
fix some positional things
dotordogh b19a407
add return statement or else error won't be processed
dotordogh f647943
fix nits. thanks @wisechengyi
dotordogh e0bd15b
Remove return statements
alexarchambault File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe more clear with the following