Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update slf4j-api to 2.0.3" #441

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Conversation

eed3si9n
Copy link
Collaborator

@eed3si9n eed3si9n commented Jan 2, 2023

Ref sbt/sbt#7062

This reverts commit 8f594cf / #422

I don't think there's any reason for lm-coursier-shaded to bring in slf4j-api 2.x series, given that underlying Coursier is still on slf4j 1.x.

@mzuehlke
Copy link

mzuehlke commented Jan 2, 2023

Maybe it would make sense to "pin" slf4j-ap to a 1.7. (or even a 1.) version range ?

In <YOUR_REPO>/.scala-steward.conf

updates.pin  = [ 
  { groupId = "org.slf4j", artifactId="slf4j-api", version = "1.7." } 
]

docs

@eed3si9n
Copy link
Collaborator Author

eed3si9n commented Jan 3, 2023

Maybe it would make sense to "pin" slf4j-ap to a 1.7. (or even a 1.) version range ?

Good idea.

@eed3si9n eed3si9n merged commit fcb67d7 into coursier:main Jan 3, 2023
@eed3si9n eed3si9n deleted the wip/revert branch January 3, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants