Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix condition in Resolvers.mavenCompatibleBaseOpt (use artifactPatterns instead of ivyPatterns) #484

Merged
merged 1 commit into from
Nov 27, 2023
Merged

fix condition in Resolvers.mavenCompatibleBaseOpt (use artifactPatterns instead of ivyPatterns) #484

merged 1 commit into from
Nov 27, 2023

Conversation

unkarjedy
Copy link
Contributor

@unkarjedy unkarjedy commented Sep 19, 2023 •
edited
Loading

Before the change Resolvers.mavenCompatibleBaseOpt always returned Some value because baseIvyPattern == baseArtifactPattern always was true

@unkarjedy
fix condition in Resolvers.mavenCompatibleBaseOpt (use artifactPatter…
0fa908c 
…ns instead of ivyPatterns)

Before the change Resolvers.mavenCompatibleBaseOpt always returned Some value because `baseIvyPattern == baseArtifactPattern` always was `true``
alexarchambault
alexarchambault approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexarchambault alexarchambault merged commit cee6474 into coursier:main Nov 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarchambault alexarchambault alexarchambault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@unkarjedy @alexarchambault