Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-empty project name for logging #489

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

kubukoz
Copy link
Contributor

@kubukoz kubukoz commented Jan 15, 2024

I've been seeing these for a long time:

[info] Resolved  dependencies
[info] Fetching artifacts of 
[info] Fetched artifacts of 
[info] Fetching artifacts of 
[info] Fetched artifacts of

Clearly something was wrong. Turns out, the string being interpolated into all these logs has been empty all along!

val projectName = "" // used for logging only…

This PR sets the value to the best thing I found in scope. Let me know if there should be a test.

@kubukoz
Copy link
Contributor Author

kubukoz commented Jan 15, 2024

@eed3si9n @alexarchambault 🙏

Copy link
Collaborator

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 8a16a57 into coursier:main Jan 16, 2024
9 checks passed
@kubukoz kubukoz deleted the log-resolution-module-name branch January 17, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants