Use JJProcessor from jarjar-abrams #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks like something I actually encountered in the wild. @alexarchambault what do you think about merging the change? |
|
Sure, if that allows the Scala metadata to be updated, definitely |
alexarchambault
approved these changes
May 23, 2024
|
@tgodzik You have enough rights to merge and cut a release, right? |
|
Yes! I just wasn't super sure about the consequences of the change 😅 |
tgodzik
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I noticed that
sbt-shadingappears to be using theMainProcessorfromjarjar, which means it doesn't shade Scala JARs properly, only Java JARs; the Scala metadata in the compiled classes ends up with the wrong package name. Sincejarjar-abramsis already a dependency, would it be possible to change it to use theJJProcessorfromjarjar-abramsinstead?