Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add precipitation weighting before fitting in prepsources #102

Open
courtiol opened this issue Sep 12, 2018 · 4 comments
Open

add precipitation weighting before fitting in prepsources #102

courtiol opened this issue Sep 12, 2018 · 4 comments

Comments

@courtiol
Copy link
Owner

There are 2 ways of weighing by precipitation amount:

  • before fitting the isoscapes
  • after fitting isoscapes per month
    Both methods have pros and cons so we should offer both method.
    So far, none work fully: "before" is not implemented and "after" does not allow for calibration.
    So let us implement the "before" method which is easy and what GNIP does.
@courtiol courtiol added this to the version 0.9 milestone Sep 12, 2018
@courtiol courtiol modified the milestones: version 0.9, version 1.0 Sep 14, 2020
@courtiol
Copy link
Owner Author

There is now a draft of how to do that in the bookdown.
But this remains very clunky, so I think that we should automate the method 1 in prepsources() and perhaps ditch the method 2 altogether from the bookdown and the examples.

@courtiol courtiol modified the milestones: version 1.0, version 0.9.1 Sep 25, 2022
@courtiol courtiol modified the milestones: version 0.9.1, version 1.0 Sep 25, 2023
@courtiol courtiol modified the milestones: version 1.0, more_flexible_isoscapes Nov 14, 2023
@courtiol courtiol self-assigned this Nov 14, 2023
@courtiol
Copy link
Owner Author

If you do think this issue matters to you, please add a thumb up!

@courtiol
Copy link
Owner Author

courtiol commented Jan 25, 2024

Short discussion with David Soto:

  • method 1 seems best
  • weighing should be done within each year separately (sum(w) = 1 for each year)
  • mean isoscape value should represent the mean of the yearly weighted means
  • residual variance should represent the variance between the yearly weighted means

This would approximate the isotopic signature of a watershed.

@courtiol
Copy link
Owner Author

courtiol commented Sep 6, 2024

Now described in the devel version of the bookdown (which will be uploaded soon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant