Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preload data when loading and discard if aborted due a violation in a… #26

Merged
merged 1 commit into from
Sep 16, 2018
Merged

Preload data when loading and discard if aborted due a violation in a… #26

merged 1 commit into from
Sep 16, 2018

Conversation

courtney-miles
Copy link
Owner

… record.

This fixes #25

@courtney-miles courtney-miles merged commit 5b0abf5 into master Sep 16, 2018
@courtney-miles courtney-miles deleted the feat/25/PreloadWithAbort branch September 16, 2018 21:27
@coveralls
Copy link

coveralls commented Sep 16, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 74

  • 76 of 96 (79.17%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 76.68%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/SlurpBuilder.php 0 5 0.0%
src/Load/DatabaseLoader/DatabaseLoader.php 14 21 66.67%
src/Load/DatabaseLoader/StagedLoad.php 31 39 79.49%
Files with Coverage Reduction New Missed Lines %
src/Load/DatabaseLoader/DatabaseLoader.php 2 77.5%
Totals Coverage Status
Change from base Build 72: 0.2%
Covered Lines: 388
Relevant Lines: 506
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preload data into a temporary table before shifting into the intended table.
2 participants
@courtney-miles @coveralls