Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slurp-36 Catch PDO Exceptions and re-throw with additional context. #37

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

courtney-miles
Copy link
Owner

#36

This PR makes changes to catch any thrown PDOExceptions and instead throw a LoadRuntimeException with a more specific exception message based on the context of the original exception.

@coveralls
Copy link

coveralls commented Aug 18, 2019

Pull Request Test Coverage Report for Build 135

  • 43 of 51 (84.31%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 91.501%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Load/DatabaseLoader/DatabaseLoader.php 23 24 95.83%
src/Load/DatabaseLoader/StagedLoad.php 2 9 22.22%
Totals Coverage Status
Change from base Build 133: -0.4%
Covered Lines: 689
Relevant Lines: 753

💛 - Coveralls

@courtney-miles courtney-miles merged commit 6820269 into release Aug 19, 2019
@courtney-miles courtney-miles deleted the imprv/36/CatchPDOExceptionAndReThrow branch January 17, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants