Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number pair metacognition task #54

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

htwangtw
Copy link
Contributor

@htwangtw htwangtw commented Feb 24, 2023

This is the WIP branch of the ICM task.

Before merging, I will remove the environment files and docker files I am using for development. The design file in data/ is also just for testing purpose.

To-dos

  • Change the time allowed for the time setting screen. Reaction time is longer when using keyboards.
  • output tsv
  • Integrate the task design generation into the event file generation
  • Discuss with Basile: best way to pre-generate the events
  • Discuss with Basile: Make the grid display prettier

Trivial things:

  • Consistency of language for describing the elements in the task
  • Name of the task in Neuromod. I found metacognition too generic for task name.

@htwangtw
Copy link
Contributor Author

Add feedback screen after each pair

@htwangtw htwangtw marked this pull request as ready for review March 29, 2023 19:04
@bpinsard
Copy link
Contributor

Testing the task I get the following crash:

Traceback (most recent call last):
  File "main.py", line 65, in <module>
    run(parsed)
  File "main.py", line 30, in run
    cli.main_loop(
  File "/home/basile/data/projects/task_stimuli/src/shared/cli.py", line 254, in main_loop
    shortcut_evt = run_task(
  File "/home/basile/data/projects/task_stimuli/src/shared/cli.py", line 75, in run_task
    shortcut_evt = run_task_loop(
  File "/home/basile/data/projects/task_stimuli/src/shared/cli.py", line 32, in run_task_loop
    for frameN, _ in enumerate(loop):
  File "/home/basile/data/projects/task_stimuli/src/tasks/task_base.py", line 107, in run
    for clearBuffer in self._run(exp_win, ctl_win):
  File "/home/basile/data/projects/task_stimuli/src/tasks/memory.py", line 228, in _run
    for item, cell in zip(items, self.grid):  # update the display
TypeError: 'float' object is not iterable

what did I do wrong?

@bpinsard
Copy link
Contributor

Testing the task I get the following crash:

Traceback (most recent call last):
  File "main.py", line 65, in <module>
    run(parsed)
  File "main.py", line 30, in run
    cli.main_loop(
  File "/home/basile/data/projects/task_stimuli/src/shared/cli.py", line 254, in main_loop
    shortcut_evt = run_task(
  File "/home/basile/data/projects/task_stimuli/src/shared/cli.py", line 75, in run_task
    shortcut_evt = run_task_loop(
  File "/home/basile/data/projects/task_stimuli/src/shared/cli.py", line 32, in run_task_loop
    for frameN, _ in enumerate(loop):
  File "/home/basile/data/projects/task_stimuli/src/tasks/task_base.py", line 107, in run
    for clearBuffer in self._run(exp_win, ctl_win):
  File "/home/basile/data/projects/task_stimuli/src/tasks/memory.py", line 228, in _run
    for item, cell in zip(items, self.grid):  # update the display
TypeError: 'float' object is not iterable

what did I do wrong?

Checking again the code,
do you not have that issue?
I just checked-out that branch, generated designs, and ran the thing, maybe your generated designs are differents?

Copy link
Contributor

@bpinsard bpinsard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't make it run yet, I suspect psychopy ImportConditions is messing up stuffs so maybe bypass it using pandas directly.

src/tasks/memory.py Outdated Show resolved Hide resolved
src/tasks/memory.py Outdated Show resolved Hide resolved
src/tasks/memory.py Show resolved Hide resolved
src/tasks/memory.py Outdated Show resolved Hide resolved
src/tasks/memory.py Outdated Show resolved Hide resolved
Co-authored-by: Basile <basile.pinsard@gmail.com>
@htwangtw
Copy link
Contributor Author

Here's

pandas              1.5.3
PsychoPy            2020.2.4.post1

@htwangtw htwangtw requested a review from bpinsard August 18, 2023 17:43
Copy link
Contributor

@bpinsard bpinsard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, mostly esthetical details.
Generated event files looks ok too, but I won't be the one analyzing that thing, so my opinion might not be sufficient.
We likely have to add fixation bullseye during ISIs to please @MarieStLaurent . :D

src/sessions/ses-numberpair.py Outdated Show resolved Hide resolved
src/tasks/memory.py Show resolved Hide resolved
src/tasks/memory.py Show resolved Hide resolved
src/tasks/memory.py Show resolved Hide resolved
src/tasks/memory.py Show resolved Hide resolved
src/tasks/memory.py Show resolved Hide resolved
src/tasks/memory.py Show resolved Hide resolved
src/tasks/memory.py Outdated Show resolved Hide resolved
@htwangtw
Copy link
Contributor Author

We likely have to add fixation bullseye during ISIs to please @MarieStLaurent . :D

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants