Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up external templates #55

Closed
kasperg opened this issue Dec 9, 2014 · 2 comments · Fixed by #58
Closed

Speed up external templates #55

kasperg opened this issue Dec 9, 2014 · 2 comments · Fixed by #58
Assignees
@mnapoli
Labels
enhancement
Milestone
1.1

Comments

@kasperg
Copy link
Contributor

kasperg commented Dec 9, 2014

If using a template from a git url the template appears to be cloned each time the site is generarted. That makes the preview process slower.

It would be nice if we could keep using the the checkout if the url does not change. To ensure we use the latest version we could pull.
mnapoli added a commit that referenced this issue Dec 9, 2014
@mnapoli
#55 In preview, avoid cloning remote repositories on every refresh
b2e0024
@mnapoli mnapoli mentioned this issue Dec 9, 2014
Merged
@mnapoli
Copy link
Member

mnapoli commented Dec 9, 2014

👍

Pulling doesn't even seem necessary to me, that would probably be as slow (or close) and wouldn't bring much. Restarting the preview seems like an acceptable compromise for ease of use.

Should be fixed when #58 is merged.

@kasperg
Copy link
Contributor Author

kasperg commented Dec 10, 2014

Sounds great.

@kasperg kasperg closed this as completed Dec 10, 2014
@kasperg kasperg reopened this Dec 10, 2014
@kasperg kasperg closed this as completed Dec 10, 2014
mnapoli added a commit that referenced this issue Dec 11, 2014
@mnapoli
#55 In preview, avoid cloning remote repositories on every refresh
11c0760
mnapoli added a commit that referenced this issue Dec 11, 2014
@mnapoli
Merge pull request #58 from CouscousPHP/remote-templates
ec574b5 
Fixes #55 and code refactoring
@mnapoli mnapoli added this to the 1.1 milestone Dec 11, 2014
@mnapoli mnapoli self-assigned this Dec 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnapoli mnapoli

Labels
enhancement
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

Fixes #55 and code refactoring CouscousPHP/Couscous
2 participants
@kasperg @mnapoli