Fix/workflow/issue milestone collector #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be homoplasy at 470N: currently, the Usher tree suggests one single event of 470N, but there are two branches with 2 private muts each and the smaller one has T16593C for which there are 2 basal French sequences, suggesting that 470N arose independently
… between 23123-27431), Guatemala, from cov-lineages#2289) with 80 seqs Resolves cov-lineages#2289
@AngieHinrichs: The V445A is probably artefactually split into two by a dropouty C29762T
…nd G22927T) Apparently most sequences on Usher lack 257V - can reinstate if it does turn out to be sizeable and real
ciscorucinski
commented
Oct 13, 2023
Comment on lines
+211
to
+215
| # - name: Download Stream Artifacts | ||
| # uses: actions/download-artifact@v3 | ||
| # with: | ||
| # name: ${{ env.STREAM_NAME }} | ||
| # path: ${{ env.SCRIPT_DIR }}/${{ env.STREAM_DIR }} |
There was a problem hiding this comment.
Commenting out these lines will prevent these files from being commited. These files are causing the JSON Check failures.
Also, the 2 json files within scripts/issue-milestone-collector/github-artifacts/api-payload/ need to be deleted. The api-payload directory can be deleted
ciscorucinski
commented
Oct 13, 2023
…ub.com/ciscorucinski/pango-designation into ciscorucinski-fix/workflow/issue-milestone-collector Conflicts: .github/workflows/issue-milestone-collector.yml scripts/issue-milestone-collector/github-artifacts/api-payload/cov-lineages_pango-designation.json scripts/issue-milestone-collector/github-artifacts/api-payload/sars-cov-2-variants_lineage-proposals.json
|
Thanks for the fix @ciscorucinski! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the JSON Check Action failure
The API Payload JSON file holds a collection of valid JSON objects concatenated together known as JSON Lines. This will fail the JSON Check Action. So I avoid committing the JSON Line files within the workflow file. I also delete the API Payload JSON files from the repo.
https://github.com/cov-lineages/pango-designation/actions/runs/6400588363