Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new recombinant lineage XAV from #911 with 59 new sequence designations, and 2 updated designations from BA.5 #984

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

InfrPopGen
Copy link
Contributor

No description provided.

…gnations, and 2 updated designations from BA.5
@InfrPopGen InfrPopGen merged commit 2477429 into cov-lineages:master Aug 23, 2022
@corneliusroemer
Copy link
Contributor

Hey @InfrPopGen, we now have these fancy duplicate checks running to prevent duplicates from ending up in the designations.

The check runs automatically on all pull requests to avoid merging them into master.

This time it failed, as you can see with the Red Cross
image

If you wait 2 minutes after creating a PR we could avoid merging duplicates by first checking for the green check.

By the way, I've written a small Python script that automatically removes old designations and overwrites with new ones.

It's as simple as running: python deduplicate_keeping_last.py from the root of the repo. That will clean up all duplicates for you.

@corneliusroemer
Copy link
Contributor

I've fixed the issue in 60d1cc7

@InfrPopGen
Copy link
Contributor Author

Thank you @corneliusroemer, I see it was "USA/OH-CDC-QDX39169817/2022 USA/OH-CDC-QDX39169817/2022,XAV" duplicated (and malformed). I usually run something to alert me, but today I updated my protocol and it ran too early. Thank you also for removing the duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants