Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lineage P.1 has 17 SNPs in note field, but only 16 in csv output #180

Closed
pmenzel opened this issue May 3, 2021 · 2 comments
Closed

Lineage P.1 has 17 SNPs in note field, but only 16 in csv output #180

pmenzel opened this issue May 3, 2021 · 2 comments

Comments

@pmenzel
Copy link
Contributor

pmenzel commented May 3, 2021

Hi,

the file variants_p1.csv has 16 columns with SNPs for the P.1 variant:

query,ref_count,alt_count,other_count,fraction_alt,aa:orf1ab:S1188L,aa:orf1ab:K1795Q,del:11288:9,aa:S:L18F,aa:S:T20N,aa:S:P26S,aa:S:D138Y,aa:S:R190S,aa:S:K417T,aa:S:E484K,aa:S:N501Y,aa:S:H655Y,aa:S:T1027I,aa:orf3a:G174C,aa:orf8:E92K,aa:N:P80R

whereas the note column in the report.csv shows x/17 detected SNPs for this lineage, probably because of the hard-coded 17 here:

note = f'{snps["alt"]}/17 P.1 (B.1.1.28.1) SNPs ({snps["ref"]} ref and {snps["oth"]} other)'

@aineniamh
Copy link
Member

Hi @pmenzel, thanks for catching that! I've updated it in the master now and the next release will have the changes incorporated.

@whottel
Copy link

whottel commented May 21, 2021

Similar to the issue originally mentioned here.
pangolearn.smk sets the denominator for P.1 to 16 even though there are only 15 listed in config_p.1.csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants