Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Information about analysis mode ends up in --all-versions output and --aliases output #420

Closed
KHajji opened this issue Apr 8, 2022 · 1 comment

Comments

@KHajji
Copy link

KHajji commented Apr 8, 2022

This seems to me to be unintended behaviour. Especially if the output of these commands is considered to be valid yaml and json in e.g. pipelines.

# Parsing analysis mode flags to return one of 'usher' or 'pangolearn'
config[KEY_ANALYSIS_MODE] = set_up_analysis_mode(args.analysis_mode, config[KEY_ANALYSIS_MODE])
print(green(f"****\nPangolin running in {config[KEY_ANALYSIS_MODE]} mode.\n****"))
if config[KEY_ANALYSIS_MODE] == "scorpio":
print(cyan(f"Warning: in `scorpio` mode only variants of concern (VOCs) defined in constellations can be assigned. `Version` column corresponds to constellation_version.\n"))
snakefile = get_snakefile(thisdir,config[KEY_ANALYSIS_MODE])
config[KEY_DESIGNATION_CACHE],config[KEY_ALIAS_FILE] = data_checks.find_designation_cache_and_alias(config[KEY_DATADIR],DESIGNATION_CACHE_FILE,ALIAS_FILE)
if args.aliases:
print_alias_file_exit(config[KEY_ALIAS_FILE])
if args.all_versions:
print_versions_exit(config)

@aineniamh
Copy link
Member

Fixed now in v4.0.4!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants