feat(website): clarify table examples #3718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdostie
force-pushed
the
ADUI-10014/simplify-table-examples
branch
from
a2d15ed
to
c45979a
Compare
gdostie
requested review from
GermainBergeron and
aboissinot-coveo
and removed request for
a team
GermainBergeron
approved these changes
May 13, 2024
FelixBlaisThon
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In this PR I made one addition to the use-table hook and several improvements to the table examples on the website.
The main fix is I added
isVacantflag on the store object. This boolean indicates whether the table has rows when unfiltered. This is useful mainly in the case of server side tables to determine whether the table should show the empty state.Potential Breaking Changes
None
Acceptance Criteria