Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sources): add missing feedback to sources api #835

Merged
merged 1 commit into from
Jun 25, 2024
Merged

feat(sources): add missing feedback to sources api #835

merged 1 commit into from
Jun 25, 2024

Conversation

ClaudineL
Copy link
Contributor

CTCORE-10099

I missed adding it to the Sources interface 😞

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@ClaudineL ClaudineL requested review from a team as code owners June 21, 2024 21:05
@ClaudineL ClaudineL added this pull request to the merge queue Jun 25, 2024
Merged via the queue into master with commit 5098b9d Jun 25, 2024
5 checks passed
@ClaudineL ClaudineL deleted the feat/CTCORE-10099-Fix-SourcesFeedback-export branch June 25, 2024 18:58
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 54.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toofff toofff toofff approved these changes

@olamothe olamothe olamothe approved these changes

@dmgauthier dmgauthier Awaiting requested review from dmgauthier dmgauthier is a code owner automatically assigned from coveo/admin-console

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ClaudineL @toofff @olamothe