Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(codeowners): add ui-tooling team to codeowners #2076

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

gdostie
Copy link
Collaborator

@gdostie gdostie commented Jul 9, 2021

Proposed Changes

Add UI Tooling as codeowners of react-vapor.

Potential Breaking Changes

none, not code related

Acceptance Criteria

  • The proposed changes are covered by unit tests
  • The potential breaking changes are clearly identified
  • README.md is adjusted to reflect the proposed changes (if relevant)

@gdostie gdostie requested a review from a team as a code owner July 9, 2021 19:21
@gdostie gdostie requested review from GermainBergeron, toofff and rosalie-liu and removed request for a team July 9, 2021 19:21
Copy link

@coveobot coveobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@GermainBergeron GermainBergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it change anything since ui-tooling is a children team of admin-console?

@gdostie
Copy link
Collaborator Author

gdostie commented Jul 12, 2021

Will it change anything since ui-tooling is a children team of admin-console?

What I think will happen is that it will assign 2 people from tooling and complete with a 3rd person from admin-console at random. But I am not 100% certain.

@gdostie gdostie merged commit bdca605 into master Jul 12, 2021
@gdostie gdostie deleted the ADUI-5194/add-ui-tooling-as-codeowners branch July 12, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants