feat(SFINT-4388) no results text when no user actions #106
Conversation
erocheleau
requested review from
mmitiche,
tedre191,
lbergeron,
nathanlb,
mikegron,
adroletCoveo,
aelfaleh,
jeremierobert-coveo and
acarpentier01
| UserActions: 'User Actions', | ||
| UserActions_no_actions_title: 'No actions available for this user', | ||
| UserActions_no_actions_causes_title: 'Potential causes', | ||
| UserActions_no_actions_cause_not_enabled: 'User actions are not enabled for your organization', | ||
| UserActions_no_actions_cause_not_associated: 'There are no user actions associated with the user', | ||
| UserActions_no_actions_cause_case_too_old: 'The case is too old to detect related actions', | ||
| UserActions_no_actions_contact_admin: 'Contact your administrator for help', |
There was a problem hiding this comment.
@acarpentier01 These are the strings. you can check on the screenshots where they are used.
| @@ -1,7 +1,13 @@ | |||
| import { Translation, Language } from '../../utils/translation'; | |||
|
|
|||
| Translation.register(Language.English, { | |||
| UserActions_no_actions: 'No actions available for this user', | |||
| UserActions: 'User Actions', | |||
| UserActions_no_actions_title: 'No actions available for this user', | |||
There was a problem hiding this comment.
| UserActions_no_actions_title: 'No actions available for this user', | |
| UserActions_no_actions_title: 'No actions available for this user.', |
There was a problem hiding this comment.
I should've specified :D the . is added but elsewhere hehe thanks for confirming I need a . though!
| UserActions: 'User Actions', | ||
| UserActions_no_actions_title: 'No actions available for this user', | ||
| UserActions_no_actions_causes_title: 'Potential causes', | ||
| UserActions_no_actions_cause_not_enabled: 'User actions are not enabled for your organization', |
There was a problem hiding this comment.
| UserActions_no_actions_cause_not_enabled: 'User actions are not enabled for your organization', | |
| UserActions_no_actions_cause_not_enabled: 'User actions are not enabled for your organization.', |
| UserActions_no_actions_title: 'No actions available for this user', | ||
| UserActions_no_actions_causes_title: 'Potential causes', | ||
| UserActions_no_actions_cause_not_enabled: 'User actions are not enabled for your organization', | ||
| UserActions_no_actions_cause_not_associated: 'There are no user actions associated with the user', |
There was a problem hiding this comment.
| UserActions_no_actions_cause_not_associated: 'There are no user actions associated with the user', | |
| UserActions_no_actions_cause_not_associated: 'There are no user actions associated with the user.', |
| UserActions_no_actions_causes_title: 'Potential causes', | ||
| UserActions_no_actions_cause_not_enabled: 'User actions are not enabled for your organization', | ||
| UserActions_no_actions_cause_not_associated: 'There are no user actions associated with the user', | ||
| UserActions_no_actions_cause_case_too_old: 'The case is too old to detect related actions', |
There was a problem hiding this comment.
| UserActions_no_actions_cause_case_too_old: 'The case is too old to detect related actions', | |
| UserActions_no_actions_cause_case_too_old: 'The case is too old to detect related actions.', |
| UserActions_no_actions_cause_not_enabled: 'User actions are not enabled for your organization', | ||
| UserActions_no_actions_cause_not_associated: 'There are no user actions associated with the user', | ||
| UserActions_no_actions_cause_case_too_old: 'The case is too old to detect related actions', | ||
| UserActions_no_actions_contact_admin: 'Contact your administrator for help', |
There was a problem hiding this comment.
| UserActions_no_actions_contact_admin: 'Contact your administrator for help', | |
| UserActions_no_actions_contact_admin: 'Contact your administrator for help.', |
| @@ -318,16 +317,33 @@ export class UserActions extends Component { | |||
| private renderNoActions() { | |||
| const element = document.createElement('div'); | |||
There was a problem hiding this comment.
For a moment, I was confused to see these two lines together. Didn't notice the this. at first.
element.innerHTML = // the whole no actions markup...
this.element.innerHTML = '';
I'd suggest to rename the element variable to emptySpace or something like that to avoid confusion with this.element. Feel free to keep the code as is if you prefer though.
There was a problem hiding this comment.
Yea good idea, I was confused about it too (not my code the element part ;) )
| element.innerHTML = ` | ||
| <div class="coveo-user-actions-title">${l(UserActions.ID)}</div> | ||
| <div>${l(UserActions.ID + '_no_actions_title')}.</div> | ||
| <br/> |
There was a problem hiding this comment.
Instead of adding <br /> tags like this, you could add a class like coveo-no-actions-section to add the top margin you want.
There was a problem hiding this comment.
I wrote a comment but it disappeared :(
Basically the thing we are displaying I consider more as a 1 paragraph than multiple HTML elements. What do you think? It felt more like a line break, than a margin between elements.
New way of explaining why there are no user actions visible.
Where the user actions are not enabled (404 response) :
When we get an error or no user actions:
