new Events and localization for AttachResult and ResultsFilter components #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added events when attaching / detaching result and filtering SNOW-182
mikegron
requested review from
tedre191,
louis-bompart and
jeremierobert-coveo
|
Take the habit of creating branches from your fork :P |
louis-bompart
requested changes
Aug 15, 2019
louis-bompart
requested changes
Aug 16, 2019
jeremierobert-coveo
requested changes
Aug 16, 2019
Added side effects files SNOW-182
jeremierobert-coveo
approved these changes
Aug 19, 2019
louis-bompart
requested changes
Aug 20, 2019
louis-bompart
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advise if I should add all events/strings in a single file for every component instead ?
Added strings for defaults strings of AttachResult and ResultsFilter
Added events when attaching / detaching result and filtering
SNOW-182