feat(sfint-3272): Add ToggleActionButton component

[lbergeron]

This PR adds the ToggleActionButton component. As its name states, it simply is an ActionButton featuring a toggle state. In addition, to keep things simple, this button supports only having an icon and tooltip. A different icon and tooltip can be displayed when the button is activated.

Using the options, the caller might attach handlers when the button is either clicked, activated, or deactivated.

[nathanlb]

Looks great! Just out of curiosity had you considered extending the ActionButton as an alternative? If yes then would you mind explaining why you went this route instead?

[lbergeron]

Looks great! Just out of curiosity had you considered extending the ActionButton as an alternative? If yes then would you mind explaining why you went this route instead?

Yes, and yes. By extending ActionButton, ToggleActionButton would also have to support all possible combinations of icon/title. Composition allows to implement only what is needed right now. If we ever need to have toggle buttons with text, it would be possible to add it.

[nathanlb]

Looks great! Just out of curiosity had you considered extending the ActionButton as an alternative? If yes then would you mind explaining why you went this route instead?

Yes, and yes. By extending ActionButton, ToggleActionButton would also have to support all possible combinations of icon/title. Composition allows to implement only what is needed right now. If we ever need to have toggle buttons with text, it would be possible to add it.

All right thanks. That was my suspicion. Well, GG! 🏆

[louis-bompart]

LGTM overall,
Some changes maybe on the variable names (I'm being picky tho).
Intrigued by the test with the spy.

[mikegron]

Très nice! J'aime bien ces petits components la :P
Question comme ca, est-ce qu'ont pourrais utiliser ce component la dans le component de AttachResult ou même le remplacer complètement, vue que lui aussi a un state de toggle avec une checkbox, mais se trouve dans le ResultActionMenu ?
Le seul truc additionnel dans AttachResult c'est l'option pour aller chercher le state initial et les custom Events de attach/detach je crois bien.

[lbergeron]

Très nice! J'aime bien ces petits components la :P
Question comme ca, est-ce qu'ont pourrais utiliser ce component la dans le component de AttachResult ou même le remplacer complètement, vue que lui aussi a un state de toggle avec une checkbox, mais se trouve dans le ResultActionMenu ?
Le seul truc additionnel dans AttachResult c'est l'option pour aller chercher le state initial et les custom Events de attach/detach je crois bien.

C'est une bonne question, je n'y avais pas songé, mais c'est vrai que les boutons ont un comportement qui se ressemble beaucoup. Je ne sais pas si le changement pourrait se faire sans briser la compatibilité par contre.

[louis-bompart]

LGTM!