Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added case and article ids to AttachResult custom events #77

Merged
merged 3 commits into from
Jul 7, 2020

Conversation

mikegron
Copy link
Collaborator

@mikegron mikegron commented Jul 3, 2020

Small addition to the AttachResult component to specify the caseId and the field where the articleId can be obtained. For ServiceNow, the articleId is pretty much always the permanentID and the caseID is static on the page. Tested using the local test page.

  • Added case and article ids to AttachResult custom events
  • Added click event when attaching in AttachResult

SNOW-364

Added click event when attaching in AttachResult
SNOW-364
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, some question and code improvement.

src/components/AttachResult/AttachResult.ts Show resolved Hide resolved
src/components/AttachResult/AttachResult.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@lbergeron lbergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some unit tests to validate the new behavior as well as the backward compatibility?

src/components/AttachResult/AttachResult.ts Show resolved Hide resolved
Copy link
Collaborator

@lbergeron lbergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit: !

@mikegron mikegron merged commit 53fe18a into coveo:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants