Fix/SFINT-3352: Ensure internal state is updated first. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
requested review from
lbergeron,
nathanlb,
jeremierobert-coveo and
enadeauCoveo
mikegron
approved these changes
Jul 28, 2020
This was referenced Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was going on.
Fix
Ensure the inner state is updated first, so
activatedis true the first time after the firstsetActivated(true)and therefore the second is no-opped.This is 'suffisant' as a fix, however, as the Panel also has a state, it's supposed to do the same checks and to update its inner states ASAP in the execution, or at the very least before doing any 'outside' communications.
This will be done in a future PR.
How was it tested.
SAN Check in SFINT
UT for new code
UT for this peculiar scenarii.
Both UT suites have been tested with and without the changeset, they do fail properly when the fix is not there ✔️