Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Actions #9

Merged
merged 8 commits into from
Jul 24, 2019
Merged

User Actions #9

merged 8 commits into from
Jul 24, 2019

Conversation

jeremierobert-coveo
Copy link
Collaborator

image

@flapierre-coveo flapierre-coveo self-requested a review July 18, 2019 19:13
mikegron
mikegron reviewed Jul 19, 2019
View reviewed changes
Copy link
Collaborator

@mikegron mikegron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:vraimentvraimentnice: !!

src/components/UserActions/DocumentsClicked.ts Outdated Show resolved Hide resolved
src/components/UserActions/DocumentsClicked.ts Outdated Show resolved Hide resolved
src/components/UserActions/ExpandableList.ts Outdated Show resolved Hide resolved
src/components/UserActions/ExpandableList.ts Outdated Show resolved Hide resolved
src/components/UserActions/Queries.ts Outdated Show resolved Hide resolved
src/components/UserActions/ResponsiveUserActions.ts Show resolved Hide resolved
src/components/UserActions/UserActivity.ts Outdated Show resolved Hide resolved
src/utils/translation.ts Outdated Show resolved Hide resolved
src/utils/time.ts Show resolved Hide resolved
erocheleau
erocheleau requested changes Jul 19, 2019
View reviewed changes
config/karma.config.js Outdated Show resolved Hide resolved
src/components/ResultsFilter/ResultsFilter.ts Show resolved Hide resolved
src/components/UserActions/DocumentsClicked.ts Outdated Show resolved Hide resolved
src/components/UserActions/DocumentsClicked.ts Outdated Show resolved Hide resolved
src/components/UserActions/DocumentsClicked.ts Outdated Show resolved Hide resolved
src/components/UserActions/UserActions.scss Outdated Show resolved Hide resolved
src/components/UserActions/UserActions.scss Outdated Show resolved Hide resolved
src/components/UserActions/UserActions.scss Outdated Show resolved Hide resolved
src/components/UserActions/UserActions.ts Outdated Show resolved Hide resolved
src/components/UserActions/UserActions.ts Outdated Show resolved Hide resolved
louis-bompart
louis-bompart requested changes Jul 22, 2019
View reviewed changes
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped last test files because I'd just repeat for the tenth time what I wrote before.
The tests are really not digest or reviewable. Try to use comments and spacing wisely to ensure they're reviewables

config/karma.config.js Outdated Show resolved Hide resolved
img/arrow-down.svg Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/UserActions/DocumentsClicked.ts Outdated Show resolved Hide resolved
src/components/UserActions/ExpandableList.ts Outdated Show resolved Hide resolved
tests/components/UserActions/ResponsiveUserActions.spec.ts Show resolved Hide resolved
tests/components/UserActions/UserActions.spec.ts Show resolved Hide resolved
tests/components/UserActions/UserActions.spec.ts Show resolved Hide resolved
tests/components/UserActions/UserActivity.spec.ts Show resolved Hide resolved
tests/utils.ts Show resolved Hide resolved
erocheleau
erocheleau requested changes Jul 22, 2019
View reviewed changes
tests/components/UserActions/DocumentsClicked.spec.ts Outdated Show resolved Hide resolved
tests/components/UserActions/DocumentsClicked.spec.ts Outdated Show resolved Hide resolved
tests/components/UserActions/Queries.spec.ts Outdated Show resolved Hide resolved
tests/components/UserActions/Queries.spec.ts Outdated Show resolved Hide resolved
tests/components/UserActions/Queries.spec.ts Outdated Show resolved Hide resolved
tests/components/UserActions/UserActivity.spec.ts Outdated Show resolved Hide resolved
tests/components/UserActions/UserActivity.spec.ts Outdated Show resolved Hide resolved
tests/components/UserActions/UserActivity.spec.ts Outdated Show resolved Hide resolved
tests/models/UserProfilingModel.spec.ts Outdated Show resolved Hide resolved
tests/rest/UserProfilingEndpoint.spec.ts Outdated Show resolved Hide resolved
tedre191
tedre191 approved these changes Jul 23, 2019
View reviewed changes
Copy link
Collaborator

@tedre191 tedre191 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, looks nice !

src/components/ResultsFilter/ResultsFilter.ts Show resolved Hide resolved
src/components/UserActions/DocumentsClicked.ts Outdated Show resolved Hide resolved
src/components/UserActions/ExpandableList.ts Show resolved Hide resolved
src/components/UserActions/Queries.ts Outdated Show resolved Hide resolved
src/components/UserActions/ResponsiveUserActions.ts Outdated Show resolved Hide resolved
jeremierobert-coveo
jeremierobert-coveo commented Jul 24, 2019
View reviewed changes
Copy link
Collaborator Author

@jeremierobert-coveo jeremierobert-coveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stremblay2

src/components/UserActions/UserActions.ts Show resolved Hide resolved
src/components/UserActions/ClickedDocumentsList.ts Outdated Show resolved Hide resolved
src/components/UserActions/ExpandableList.ts Show resolved Hide resolved
src/components/UserActions/Strings.ts Show resolved Hide resolved
src/components/UserActions/UserActions.ts Show resolved Hide resolved
src/components/UserActions/UserActions.ts Show resolved Hide resolved
src/components/UserActions/UserActions.ts Outdated Show resolved Hide resolved
louis-bompart
louis-bompart approved these changes Jul 24, 2019
View reviewed changes
src/components/UserActions/ClickedDocumentsList.ts Outdated Show resolved Hide resolved
src/components/UserActions/QueriesList.ts Outdated Show resolved Hide resolved
src/components/UserActions/ResponsiveUserActions.ts Show resolved Hide resolved
src/components/UserActions/Strings.ts Show resolved Hide resolved
src/components/UserActions/UserActions.ts Show resolved Hide resolved
tests/rest/UserProfilingEndpoint.spec.ts Show resolved Hide resolved
tests/rest/UserProfilingEndpoint.spec.ts Show resolved Hide resolved
tests/models/UserProfilingModel.spec.ts Show resolved Hide resolved
tests/models/UserProfilingModel.spec.ts Show resolved Hide resolved
tests/models/UserProfilingModel.spec.ts Show resolved Hide resolved
erocheleau
erocheleau approved these changes Jul 24, 2019
View reviewed changes
Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the last discussions I re-opened and it's approved.

@jeremierobert-coveo jeremierobert-coveo merged commit c951714 into coveo:master Jul 24, 2019
@jeremierobert-coveo jeremierobert-coveo deleted the user-actions-scroll branch July 24, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stremblay2 Stremblay2 Stremblay2 left review comments

@tedre191 tedre191 tedre191 approved these changes

@erocheleau erocheleau erocheleau approved these changes

@louis-bompart louis-bompart louis-bompart approved these changes

@flapierre-coveo flapierre-coveo Awaiting requested review from flapierre-coveo

@mikegron mikegron Awaiting requested review from mikegron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jeremierobert-coveo @tedre191 @erocheleau @mikegron @louis-bompart @Stremblay2