Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/snow 494 jenkins #96

Merged
merged 4 commits into from
Mar 9, 2021
Merged

Conversation

mikegron
Copy link
Collaborator

@mikegron mikegron commented Mar 8, 2021

Added the deployment config from the old repo to this one to be able to deploy to the CDN automatically using the deployment pipeline when we push a tag.

mikegron and others added 3 commits January 7, 2021 14:25
Added Jenkins and deployment package configuration
SNOW-494
SNOW-494
stage("Test package") {
steps {
withCredentials([string(credentialsId: 'snyk_token', variable: 'SNYK_TOKEN')]) {
runSnyk(org: "coveo-jsui", directory: ".")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to provide credentials here?

Copy link

@dguerinCoveo dguerinCoveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La seule chose que je changerais serait les noms des steps peut-etre. La step de "build" contient aussi les tests, faq peut-etre "Build and Test" et la step "Test Package" fait juste snyk faq peut etre changer pour "validate dependencies" ou "Run Snyk"

@mikegron mikegron merged commit baf6b98 into coveo:master Mar 9, 2021
@mikegron mikegron deleted the feature/SNOW-494-jenkins branch March 9, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants