JSUI-2404 Don't send the "tab" parameter to querySuggest if it's an e…

…mpty string (#1042)

* Don't send the "tab" parameter to querySuggest if it's an empty string

https://coveord.atlassian.net/browse/JSUI-2404

src/ui/Omnibox/QuerySuggestAddon.ts

@@ -15,6 +15,7 @@ import { map, every, last, indexOf, find } from 'underscore';
 import { QUERY_STATE_ATTRIBUTES } from '../../models/QueryStateModel';
 import { history } from 'coveo.analytics';
 import { Cookie } from '../../utils/CookieUtils';
+import { Utils } from '../../utils/Utils';
 
 export interface IQuerySuggestAddon {
   getSuggestion(): Promise<IOmniboxSuggestion[]>;
@@ -112,7 +113,13 @@ export class QuerySuggestAddon implements IQuerySuggestAddon {
   }
 
   private get tab() {
-    return this.omnibox.getBindings().queryStateModel.get(QUERY_STATE_ATTRIBUTES.T) as string;
+    const tab = this.omnibox.getBindings().queryStateModel.get(QUERY_STATE_ATTRIBUTES.T) as string;
+
+    if (Utils.isNonEmptyString(tab)) {
+      return tab;
+    }
+
+    return undefined;
   }
 
   private get locale() {

unitTests/ui/QuerySuggestAddonTest.ts

@@ -75,6 +75,16 @@ export function QuerySuggestAddonTest() {
         done();
       });
 
+      it("without the tab if it's empty", async done => {
+        (omnibox.env.queryStateModel.get as jasmine.Spy).and.callFake(
+          (param: string) => (param == QUERY_STATE_ATTRIBUTES.T ? '' : 'something else')
+        );
+        querySuggest = new QuerySuggestAddon(omnibox.cmp);
+        await querySuggest.getSuggestion();
+        spyShouldHaveBeenCalledWith('tab', undefined);
+        done();
+      });
+
       it('with enableWordCompletion', async done => {
         omnibox.cmp.options.enableSearchAsYouType = true;
         querySuggest = new QuerySuggestAddon(omnibox.cmp);