JSUI-2786 Added beta and feature deployments to CDN #1550

btaillon-coveo · 2020-07-13T18:45:27Z

https://coveord.atlassian.net/browse/JSUI-2786

This PR introduces the two following deployments to CDN:

Beta → https://static.cloud.coveo.com/searchui/nightly/ (overwrites the previous beta build in the CDN)
- Triggered only by cron events adding the -beta tag
JSUI-* → https://staticdev.cloud.coveo.com/searchui/pr/JSUI-*/
- Triggered only on the new continuous-integration/travis-ci/push builds

As well as introducing those two deployments, this PR adds the continuous-integration/travis-ci/push build, which is responsible for deploying to the CDN.

…ilds https://coveord.atlassian.net/browse/JSUI-2786

btaillon-coveo · 2020-07-13T18:54:31Z

.travis.yml

+    on:
+      repo: coveo/search-ui
+      all_branches: true
+      condition: "$IS_FEATURE == true"


I'm afraid I might not have enough permissions to revert a bad build, bad release or bad upload to CDN if I've made a mistake. I'm going to wait until the rest of this file is approved and @olamothe is available before making the following change:

branches: only: - master - "/^.*release.*$/" - "/2\\.[0-9]+\\.[0-9]+/"

is going to be changed to

branches: only: - master - "/^.*release.*$/" - "/2\\.[0-9]+\\.[0-9]+/" - "/^JSUI-[0-9]+$/"

Wouldn't IS_FEATURE be true only for the last branch format? ^JSUI-[0-9]+$

Yes, and every other should be false for said format. So it should work, but in the event that I missed something, I wanted to get this reviewed first.

Adding this line will run every above conditions on ^JSUI-[0-9]+$ branches.

I would remove the $ at the end, branches name with something else after the JIRA tag are valid

Alright, I'll count those as feature branches too.

coveralls · 2020-07-13T19:06:28Z

Coverage remained the same at 89.381% when pulling a48171b on JSUI-2786 into 4306b31 on master.

https://coveord.atlassian.net/browse/JSUI-2786

btaillon-coveo · 2020-07-13T20:43:53Z

.travis.yml

+  - export SOURCE_BRANCH=${TRAVIS_PULL_REQUEST_BRANCH:-$TRAVIS_BRANCH}
+  - export IS_FORKED_PULL_REQUEST=$([[ $TRAVIS_PULL_REQUEST != false && $TRAVIS_PULL_REQUEST_SLUG != $TRAVIS_REPO_SLUG ]] && echo true || echo false)
+  - export IS_BETA=$([[ $TRAVIS_TAG =~ .*beta.* && $IS_FORKED_PULL_REQUEST = false ]] && echo true || echo false)
+  - export IS_RELEASE=$([[ $SOURCE_BRANCH =~ ^.*release.*$|^master$ && $IS_FORKED_PULL_REQUEST = false ]] && echo true || echo false)
+  - export IS_FEATURE=$([[ $SOURCE_BRANCH =~ ^JSUI-[0-9]+$ && $IS_FORKED_PULL_REQUEST = false ]] && echo true || echo false)


These variables are introduced to improve the readability of the conditions.

They contain "true" and "false" instead of 0 and 1 to avoid ambiguity.

IS_RELEASE is evaluated by the ^.*release.*$|^master$ regular expression instead of the ! $TRAVIS_TAG =~ .*beta.* regular expression since these conditions are also going to be evaluated on JSUI-* branches, from now on.

Values tested on this PR:

Values tested on a fork's PR:

samisayegh

Nice touch screening out fork pull requests 💯

samisayegh · 2020-07-14T13:03:39Z

.travis.yml

+  - export SOURCE_BRANCH=${TRAVIS_PULL_REQUEST_BRANCH:-$TRAVIS_BRANCH}
+  - export IS_FORKED_PULL_REQUEST=$([[ $TRAVIS_PULL_REQUEST != false && $TRAVIS_PULL_REQUEST_SLUG != $TRAVIS_REPO_SLUG ]] && echo true || echo false)
+  - export IS_BETA=$([[ $TRAVIS_TAG =~ .*beta.* && $IS_FORKED_PULL_REQUEST = false ]] && echo true || echo false)
+  - export IS_RELEASE=$([[ $SOURCE_BRANCH =~ ^.*release.*$|^master$ && $IS_FORKED_PULL_REQUEST = false ]] && echo true || echo false)


I think we can remove ^master$ from the source branch regex, since our releases occur on release branches? Or is this for the nightly build? If so, I would prefer to create a separate variable IS_NIGHTLY. I think it will be helpful to distinguish this release from an official release.

For the official release branches, the format, is <year>-<month>-release. I think we can mark release as the end of the regex. We could also be more strict if the regex was looking for 4 numbers|dash|some lowercase letters|dash|release.
e.g. ^[0-9]{4}-[a-z]+-release$.

But we could keep it as just ends with release too.

Yup, I'll remove ^master$. Additionally, I realized that the requirement for a commit to count as a release isn't the name of the branch, but rather the tag given to the commit. I'll change the condition.

For nightly builds, they correspond with IS_BETA, since betas are tagged every day.

As for the format, I agree and I'll make it more strict. However, the condition will no longer be on the branch, it'll be on the tag.

samisayegh · 2020-07-14T13:22:29Z

.travis.yml

+    on:
+      repo: coveo/search-ui
+      all_branches: true
+      condition: "$IS_FEATURE == true"


Wouldn't IS_FEATURE be true only for the last branch format? ^JSUI-[0-9]+$

samisayegh · 2020-07-14T13:25:32Z

.travis.yml

+    access_key_id: AKIAYKDJLZIT462WODCI
+    secret_access_key:
+      secure: sT8isIiaAIg/Ic7x8cCD3anwCEHAyzG/IWkngmkf5c128NEwUIUdmsQJ1hi4Bw84zk1OOb3id+yXjeaTuKDgIkxe/jk3e2xZ7xElfLNTOln6QLkgsYpKFtGHiKjROOHOb5+Es6L1mxpHWbXH9ebmEhRduUw/BeHWW2MfZmfb434DgvatViRm8DOeROeqlYnbCda5ZELuT5SdwEs/CbExaiSL0WKVoTvcxbe+At4uVnTuc6SYyOvRoblx/q6Ra6mdRipluMs7Go93eu/Oqo7cZ2akrNSi/WBXGqL/wXxe2pYsziSABWjQaqWXD/jKte1ZBx7OXssn88DUKat/RrL7Ak30WHzgY/goiNV+EPT/wtNYWHP3suAzzGqNNMhsPx0lSI7vSUga72J3hV1TOsX9ORosiRm1c2fnmNB9vJdH7yAX7lWpqH2XuOrldVvvTGazSJYx93eBukDViFCZ6egeb+gMT8VQ38uitwd9BZaMhycoujZgSjhx7JnbHUoUdXkdT3XBNV7fINTozWCNJW81iJN+JuLZzneJ/CbjmjkfGcVoFFPCD9rGSj8DbgvWpt8rkwI4ZfHTNOgO9iWgSklpk9r2wgM7Z87V2Zpu8UX/QCFxy8IREtJUo6X9YG9nBoy21wUa9zia2SWpideur9cXb6U0+q84onHVlA0Ehp/1OYs=
+    bucket: coveo-nprod-binaries


We should adjust the bucket to coveo-ndev-binaries here to avoid mixing feature deployments with the official releases.

Same comment for line 111 holding the nightly build.

Small note is these buckets will be accessible under staticdev.cloud instead of static.cloud, which I think is good.

@olamothe mentioned that, to make it simpler, we should push all of those to the prod CDN. Perhaps we need to have a discussion on it?

My thinking behind the comment was to keep the prod bucket tidy by just holding official releases, and to keep the traffic separated.

I think it's good to keep our sandbox from sharing resources with our production files. We can delete everything (intentionally/unintentionally) without fear. In the prod bucket, our permissions are restricted, rightly so.

I agree, I'd expect nightly and feature builds to be in the dev bucket.

Yes, dev bucket is perfectly fine.

When I initially opened this JSUI ticket and we had the discussion many months ago, there was no bucket/CDN in dev/qa/prod.

But @samisayegh did the work of terraforming those since then.

And for dev, the encrypted secret_access_key you are using won't work.

We will need to generate a new one for dev account that can only do this operation (push to this particular bucket) in AWS.

Awesome, I'll do that, then.

https://coveord.atlassian.net/browse/JSUI-2786

btaillon-coveo · 2020-07-15T19:03:15Z

.travis.yml

+  - export SOURCE_BRANCH=${TRAVIS_PULL_REQUEST_BRANCH:-$TRAVIS_BRANCH}
+  - export IS_FORKED_PULL_REQUEST=$([[ $TRAVIS_PULL_REQUEST != false && $TRAVIS_PULL_REQUEST_SLUG != $TRAVIS_REPO_SLUG ]] && echo true || echo false)
+  - export HAS_BETA_TAG=$([[ $TRAVIS_TAG =~ ^[0-9]+\.[0-9]+\.[0-9]+-beta$ && $IS_FORKED_PULL_REQUEST = false ]] && echo true || echo false)
+  - export HAS_RELEASE_TAG=$([[ $TRAVIS_TAG =~ ^[0-9]+\.[0-9]+\.[0-9]+$ && $IS_FORKED_PULL_REQUEST = false ]] && echo true || echo false)
+  - export IS_ON_FEATURE_BRANCH=$([[ $SOURCE_BRANCH =~ ^JSUI-[0-9]+ && $IS_FORKED_PULL_REQUEST = false ]] && echo true || echo false)


Betas are triggered by a tagged commit on the master branch and releases are triggered by a tagged commit on a release branch. Should I also enforce the branch or only enforce the tag?

I'd go with just one or the other. I think tag is enough.

btaillon-coveo · 2020-07-15T19:10:15Z

Unfortunately, the changes I just made changed the behaviour of the CI a bit too much, so I must request a new review 😅

samisayegh · 2020-07-15T19:44:30Z

.travis.yml

+  - export SOURCE_BRANCH=${TRAVIS_PULL_REQUEST_BRANCH:-$TRAVIS_BRANCH}
+  - export IS_FORKED_PULL_REQUEST=$([[ $TRAVIS_PULL_REQUEST != false && $TRAVIS_PULL_REQUEST_SLUG != $TRAVIS_REPO_SLUG ]] && echo true || echo false)
+  - export HAS_BETA_TAG=$([[ $TRAVIS_TAG =~ ^[0-9]+\.[0-9]+\.[0-9]+-beta$ && $IS_FORKED_PULL_REQUEST = false ]] && echo true || echo false)
+  - export HAS_RELEASE_TAG=$([[ $TRAVIS_TAG =~ ^[0-9]+\.[0-9]+\.[0-9]+$ && $IS_FORKED_PULL_REQUEST = false ]] && echo true || echo false)
+  - export IS_ON_FEATURE_BRANCH=$([[ $SOURCE_BRANCH =~ ^JSUI-[0-9]+ && $IS_FORKED_PULL_REQUEST = false ]] && echo true || echo false)


I'd go with just one or the other. I think tag is enough.

samisayegh · 2020-07-15T19:52:50Z

.travis.yml

+    access_key_id: AKIAYKDJLZIT462WODCI
+    secret_access_key:
+      secure: sT8isIiaAIg/Ic7x8cCD3anwCEHAyzG/IWkngmkf5c128NEwUIUdmsQJ1hi4Bw84zk1OOb3id+yXjeaTuKDgIkxe/jk3e2xZ7xElfLNTOln6QLkgsYpKFtGHiKjROOHOb5+Es6L1mxpHWbXH9ebmEhRduUw/BeHWW2MfZmfb434DgvatViRm8DOeROeqlYnbCda5ZELuT5SdwEs/CbExaiSL0WKVoTvcxbe+At4uVnTuc6SYyOvRoblx/q6Ra6mdRipluMs7Go93eu/Oqo7cZ2akrNSi/WBXGqL/wXxe2pYsziSABWjQaqWXD/jKte1ZBx7OXssn88DUKat/RrL7Ak30WHzgY/goiNV+EPT/wtNYWHP3suAzzGqNNMhsPx0lSI7vSUga72J3hV1TOsX9ORosiRm1c2fnmNB9vJdH7yAX7lWpqH2XuOrldVvvTGazSJYx93eBukDViFCZ6egeb+gMT8VQ38uitwd9BZaMhycoujZgSjhx7JnbHUoUdXkdT3XBNV7fINTozWCNJW81iJN+JuLZzneJ/CbjmjkfGcVoFFPCD9rGSj8DbgvWpt8rkwI4ZfHTNOgO9iWgSklpk9r2wgM7Z87V2Zpu8UX/QCFxy8IREtJUo6X9YG9nBoy21wUa9zia2SWpideur9cXb6U0+q84onHVlA0Ehp/1OYs=
+    bucket: coveo-nprod-binaries


My thinking behind the comment was to keep the prod bucket tidy by just holding official releases, and to keep the traffic separated.

I think it's good to keep our sandbox from sharing resources with our production files. We can delete everything (intentionally/unintentionally) without fear. In the prod bucket, our permissions are restricted, rightly so.

https://coveord.atlassian.net/browse/JSUI-2786

…SUI-2786 https://coveord.atlassian.net/browse/JSUI-2786

https://coveord.atlassian.net/browse/JSUI-2786

btaillon-coveo · 2020-09-24T14:58:50Z

.travis.yml

+  - export HAS_RELEASE_TAG=$([[ $TRAVIS_TAG =~ ^[0-9]+\.[0-9]+\.[0-9]+$ && $IS_FORKED_PULL_REQUEST = false ]] && echo true || echo false)
+  - export IS_ON_FEATURE_BRANCH=$([[ $SOURCE_BRANCH =~ ^JSUI-[0-9]+ && $IS_FORKED_PULL_REQUEST = false ]] && echo true || echo false)
+  - export IS_NIGHTLY=$([[ $HAS_BETA_TAG = true && $TRAVIS_EVENT_TYPE = cron ]] && echo true || echo false)
+  - export IS_PULL_REQUEST_PUSH_BUILD=$([[ $TRAVIS_PULL_REQUEST = false && $IS_ON_FEATURE_BRANCH = true ]] && echo true || echo false)


This is only true on continuous-integration/travis-ci/push builds.

Looking back at this, I'm realizing that this would likely cause push builds to be triggered on JSUI-* branches, whether they have a PR or not. However, for certain features like QuestionAnswering (JSUI-2049) that don't necessarily have an open PR, this could be beneficial.

@samisayegh @ThibodeauJF any opinion?

I think pushing all JSUI-* branches is fine. Let's start with this. If we see it is too for some reason, we can adjust.

btaillon-coveo · 2020-09-24T14:59:50Z

.travis.yml

+  - echo $TRAVIS_BRANCH
+  - echo $TRAVIS_PULL_REQUEST_BRANCH
+  - echo $TRAVIS_PULL_REQUEST
+  - echo $SOURCE_BRANCH
+  - echo $IS_FORKED_PULL_REQUEST
+  - echo $HAS_BETA_TAG
+  - echo $HAS_RELEASE_TAG
+  - echo $IS_ON_FEATURE_BRANCH
+  - echo $IS_NIGHTLY
+  - echo $IS_PULL_REQUEST_PUSH_BUILD


Should I keep those echo? In case anything happens, those would most likely help find the problem.

Sure, should we put the name of the tag next to the boolean value? I imagine as it is now we would only see a series of true and false in the console?

btaillon-coveo · 2020-09-24T15:01:22Z

.travis.yml

 - if [ "x$TRAVIS_TAG" != "x" ]; then yarn run minimize ; fi
- yarn run unitTests
- if [ "x$TRAVIS_TAG" != "x" ]; then yarn run accessibilityTests ; fi
+- if [ $IS_PULL_REQUEST_PUSH_BUILD = false ]; then yarn run unitTests ; fi
+- if [[ "x$TRAVIS_TAG" != "x" && $IS_PULL_REQUEST_PUSH_BUILD = false ]]; then yarn run accessibilityTests ; fi
 - set +e
- yarn run uploadCoverage
+- if [ $IS_PULL_REQUEST_PUSH_BUILD = false ]; then yarn run uploadCoverage ; fi
 - set -e
- yarn run validateTypeDefinitions
+- if [ $IS_PULL_REQUEST_PUSH_BUILD = false ]; then yarn run validateTypeDefinitions ; fi
 after_success:
- if [ "x$TRAVIS_TAG" != "x" ]; then bash ./deploy.doc.sh ; fi
+- if [[ "x$TRAVIS_TAG" != "x" && $IS_PULL_REQUEST_PUSH_BUILD = false ]]; then bash ./deploy.doc.sh ; fi


On continuous-integration/travis-ci/push builds, we probably don't want to:

minimize

run unit tests

upload coverage

validate type definitions

deploy documentation

btaillon-coveo · 2020-09-24T15:04:15Z

.travis.yml

+    on:
+      repo: coveo/search-ui
+      all_branches: true
+      condition: "$IS_PULL_REQUEST_PUSH_BUILD == true"


Deployment providers can't be run on a continuous-integration/travis-ci/pr build. There's probably a way to make that work, but continuous-integration/travis-ci/pr pull changes from master and their builds seem to be mostly for testing anyways.

btaillon-coveo · 2020-09-24T15:11:35Z

.travis.yml

@@ -106,3 +151,4 @@ branches:
  - master
  - "/^.*release.*$/"
  - "/2\\.[0-9]+\\.[0-9]+/"
+  - "/^JSUI-[0-9]+/"


continuous-integration/travis-ci/push builds are triggered by a Travis option on the repo that happened to be already selected, but they weren't triggered before due to the lack of this line.

samisayegh · 2020-09-24T18:41:52Z

.travis.yml

+  - echo $TRAVIS_BRANCH
+  - echo $TRAVIS_PULL_REQUEST_BRANCH
+  - echo $TRAVIS_PULL_REQUEST
+  - echo $SOURCE_BRANCH
+  - echo $IS_FORKED_PULL_REQUEST
+  - echo $HAS_BETA_TAG
+  - echo $HAS_RELEASE_TAG
+  - echo $IS_ON_FEATURE_BRANCH
+  - echo $IS_NIGHTLY
+  - echo $IS_PULL_REQUEST_PUSH_BUILD


Sure, should we put the name of the tag next to the boolean value? I imagine as it is now we would only see a series of true and false in the console?

btaillon-coveo · 2020-09-24T18:49:00Z

@samisayegh That's what I originally tried to do, but Travis outputs every command above their respective output and even collapses the output of echo by default, making it redundant.

introduced conditional build variables and added nightly & feature bu…

c4d49be

…ilds https://coveord.atlassian.net/browse/JSUI-2786

btaillon-coveo requested review from olamothe, samisayegh and ThibodeauJF as code owners July 13, 2020 18:45

btaillon-coveo commented Jul 13, 2020

View reviewed changes

btaillon-coveo added 3 commits July 13, 2020 15:07

fixed source branch name for pull requests

ed9e40a

https://coveord.atlassian.net/browse/JSUI-2786

Temporarily making travis echo the evaluated variables

b45f8a3

https://coveord.atlassian.net/browse/JSUI-2786

Reverted making travis echo the evaluated variables

738aa1d

https://coveord.atlassian.net/browse/JSUI-2786

btaillon-coveo closed this Jul 13, 2020

Prevented deployment trigged by pull requests from forks

6d18a0c

https://coveord.atlassian.net/browse/JSUI-2786

btaillon-coveo reopened this Jul 13, 2020

Fixed references to $IS_FORKED_PULL_REQUEST

154b7a0

https://coveord.atlassian.net/browse/JSUI-2786

btaillon-coveo closed this Jul 13, 2020

btaillon-coveo reopened this Jul 13, 2020

btaillon-coveo added 2 commits July 13, 2020 16:36

Fixed detection of forked pull requests

e999341

https://coveord.atlassian.net/browse/JSUI-2786

Removed unneeded echo and reordered variables

29db891

https://coveord.atlassian.net/browse/JSUI-2786

btaillon-coveo commented Jul 13, 2020

View reviewed changes

samisayegh approved these changes Jul 14, 2020

View reviewed changes

ThibodeauJF approved these changes Jul 15, 2020

View reviewed changes

Made beta and release conditions stricter

c325c19

https://coveord.atlassian.net/browse/JSUI-2786

btaillon-coveo commented Jul 15, 2020

View reviewed changes

btaillon-coveo requested review from ThibodeauJF and samisayegh July 15, 2020 19:09

samisayegh approved these changes Jul 15, 2020

View reviewed changes

ThibodeauJF approved these changes Jul 15, 2020

View reviewed changes

Introduced IS_NIGHTLY condition

cb4ce5b

https://coveord.atlassian.net/browse/JSUI-2786

olamothe approved these changes Jul 20, 2020

View reviewed changes

btaillon-coveo and others added 15 commits September 23, 2020 10:23

Added pull-requests subdirectory

af12400

https://coveord.atlassian.net/browse/JSUI-2786

Shortened "pull-requests" to "pr"

d918420

https://coveord.atlassian.net/browse/JSUI-2786

Removed JSUI matcher in branches

62bfd08

https://coveord.atlassian.net/browse/JSUI-2786

Printing variables

69b89c6

https://coveord.atlassian.net/browse/JSUI-2786

Fixed echo

6a07d1c

https://coveord.atlassian.net/browse/JSUI-2786

Adding more install info and re-added JSUI branch matcher

08280ce

https://coveord.atlassian.net/browse/JSUI-2786

Introduced $IS_PUSH_BUILD variable

2be2f10

https://coveord.atlassian.net/browse/JSUI-2786

Fixed OR and AND conditions in .travis.yml

a0311f7

https://coveord.atlassian.net/browse/JSUI-2786

Making unit tests fail

004f8f5

https://coveord.atlassian.net/browse/JSUI-2786

Merge branch 'master' into JSUI-2786

b3cb6cb

Fixed unit tests

5b65aa2

https://coveord.atlassian.net/browse/JSUI-2786

Renamed IS_PUSH_BUILD to IS_PULL_REQUEST_PUSH_BUILD

52c5ea9

https://coveord.atlassian.net/browse/JSUI-2786

Set ACL to public_read

47d4ce3

https://coveord.atlassian.net/browse/JSUI-2786

Merge branch 'JSUI-2786' of https://github.com/coveo/search-ui into J…

c15b8b7

…SUI-2786 https://coveord.atlassian.net/browse/JSUI-2786

Stopped running minimize on push builds

d36141d

https://coveord.atlassian.net/browse/JSUI-2786

btaillon-coveo commented Sep 24, 2020

View reviewed changes

btaillon-coveo requested review from olamothe, samisayegh and ThibodeauJF September 24, 2020 15:06

btaillon-coveo commented Sep 24, 2020

View reviewed changes

samisayegh approved these changes Sep 24, 2020

View reviewed changes

ThibodeauJF approved these changes Sep 24, 2020

View reviewed changes

btaillon-coveo added 2 commits September 30, 2020 10:45

Merge branch 'master' into JSUI-2786

8d2930f

Merge branch 'master' into JSUI-2786

a48171b

btaillon-coveo merged commit e09e93f into master Oct 15, 2020

btaillon-coveo deleted the JSUI-2786 branch May 4, 2022 12:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JSUI-2786 Added beta and feature deployments to CDN #1550

JSUI-2786 Added beta and feature deployments to CDN #1550

btaillon-coveo commented Jul 13, 2020 •

edited

btaillon-coveo Jul 13, 2020

samisayegh Jul 14, 2020

btaillon-coveo Jul 14, 2020 •

edited

ThibodeauJF Jul 15, 2020

btaillon-coveo Jul 15, 2020

coveralls commented Jul 13, 2020 •

edited

btaillon-coveo Jul 13, 2020

samisayegh left a comment

samisayegh Jul 14, 2020

btaillon-coveo Jul 15, 2020 •

edited

samisayegh Jul 14, 2020

samisayegh Jul 14, 2020

btaillon-coveo Jul 15, 2020

samisayegh Jul 15, 2020

btaillon-coveo Jul 15, 2020

olamothe Jul 15, 2020

olamothe Jul 15, 2020

btaillon-coveo Jul 16, 2020

btaillon-coveo Jul 15, 2020

samisayegh Jul 15, 2020

btaillon-coveo commented Jul 15, 2020 •

edited

samisayegh Jul 15, 2020

samisayegh Jul 15, 2020

btaillon-coveo Sep 24, 2020

btaillon-coveo Sep 30, 2020

samisayegh Sep 30, 2020

btaillon-coveo Sep 24, 2020

samisayegh Sep 24, 2020

btaillon-coveo Sep 24, 2020

btaillon-coveo Sep 24, 2020

btaillon-coveo Sep 24, 2020

samisayegh Sep 24, 2020

btaillon-coveo commented Sep 24, 2020 •

edited

JSUI-2786 Added beta and feature deployments to CDN #1550

JSUI-2786 Added beta and feature deployments to CDN #1550

Conversation

btaillon-coveo commented Jul 13, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

btaillon-coveo Jul 14, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Jul 13, 2020 • edited

Choose a reason for hiding this comment

samisayegh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

btaillon-coveo Jul 15, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

btaillon-coveo commented Jul 15, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

btaillon-coveo commented Sep 24, 2020 • edited

btaillon-coveo commented Jul 13, 2020 •

edited

btaillon-coveo Jul 14, 2020 •

edited

coveralls commented Jul 13, 2020 •

edited

btaillon-coveo Jul 15, 2020 •

edited

btaillon-coveo commented Jul 15, 2020 •

edited

btaillon-coveo commented Sep 24, 2020 •

edited