fix(slider): should round value when dateField=true #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
requested review from
olamothe,
y-lakhdar and
fpbrault-dev
and removed request for
a team
louis-bompart
changed the title
louis-bompart
commented
Mar 7, 2024
| @@ -77,6 +77,37 @@ export function SliderTest() { | |||
| expect(slider.getValues()).toEqual([25, 75]); | |||
| }); | |||
|
|
|||
| it('should return round values when using dateField', () => { | |||
There was a problem hiding this comment.
Tests here are a bit lazy and do not really respect encapsulation, but I think it's fine because this allow the test to get to the point and test actually what's wrong without having over the top setup.
olamothe
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using DATE field, we do not support sub-second precision https://connect.coveo.com/s/article/14754
So let's round it up when dateField=true.
https://coveord.atlassian.net/browse/JSUI-3510