-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thumbnail doc revision #306
Conversation
I went a little bit further than a simple spell check for those first few components. I will limit myself to a quick spell checks for the next components, though.
- Added link to IGroupByRequest interface. - Made a tiny correction. - Changed HTML link to markdown link.
- Reexposing selectSuggestion(suggestion: number) instead of selectSuggestion(suggestion: any) in public documentation.
…ation: - "Standardized" bindings description in constructor documentation.
- Corrected a leftover spelling mistake. - Some rephrasing and improvements. - Unexposed options (this component has no option). - Unexposed validLayouts static attribute (redundant with ValidLayout type) and currentLayout attribute (redundant with getCurrentLayout() method). - Linked to ValidLayout type documentation.
* Default value is <code>false</code> | ||
* Specifies whether to create a clickable {@link ResultLink} around the Thumbnail. | ||
* | ||
* Uses all the same options as a {@link ResultLink} except for {@link ResultLink.options.field}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following markup:
<div class='CoveoThumbnail' data-clickable='true' data-always-open-in-new-window='true'></div>
generates something like this:
<div class='CoveoThumbnail CoveoResultLink' data-clickable='true' data-always-open-in-new-window='true' tabindex='0'>['name of file.ext']
<img src=['image URL']>
</div>
however, the data-always-open-in-new-window
option has no actual effect; clicking the thumbnail (or the result link displayed above it) still opens the image in the current window.
The same goes for other options such as data-open-quickview
.
Is there another way to specify options for the generated CoveoResultLink
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be a bug then.
Can you open one in jira ? We'll have a look at it.
See DOC-458