delayed first width check when zero for reponsive components #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olamothe
requested changes
Feb 22, 2017
| this.coveoRoot.addClass('coveo-small-interface'); | ||
| } else if (!this.shouldSwitchToSmallMode()) { | ||
| this.coveoRoot.removeClass('coveo-small-interface'); | ||
| if (this.coveoRoot.width() != 0) { |
There was a problem hiding this comment.
It's getting a bit convoluted in here...
In any case, I would at least add some information with the Logger to inform potential dev why the ResponsiveComponentsManager cannot do it's job.
Maybe even some info that points to possible solution :
eg : SearchInterface is display none
There was a problem hiding this comment.
Also, explaining the consequence of this would be useful (explaining that facet won't hide in a menu, tabs, won't resize correctly in a dropdown, etc.)
olamothe
approved these changes
Feb 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/JSUI-1431